[CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887

sarious · 2023-11-04T20:03:31Z

@fedirjh @luacmartins

Details

I moved the minHeight style to the root View, because the child View has some paddings. (just put it in KeyboardAvoidingView because of maxWeight). Also because of that we don't need to calculate insets in useInitialWindowDimensions hook.
I've got rid of shouldEnableMaxHeight and added shouldEnableKeyboardAvoidingView={false} to EditRequestAmountPage page to behave the same as MoneyRequestSelectorPage page and fix an issue when go back from currency selector

Fixed Issues

$ #17866
PROPOSAL: #17866 (comment)

Fix of the issue with offline mode:
#30840

Tests

Case with adding money request:

Launch New Expensify app.
Tap + > Request money.
Enter amount of money
Press next
Go back
Verify that the keyboard does not flash.

Case with editing money request:

Launch New Expensify app.
Tap + > Request money.
Create a manual request.
Open the IOU details view
Tap Amount
Select some currency.
Go back
Verify that the keyboard does not flash.

Verify that no errors appear in the JS console

Offline tests

Case with adding money request:

Launch New Expensify app.
Force "Offline" mode
Tap + > Request money.
Enter amount of money
Press next
Go back
Verify offline message will not overlap with the white navigation bar (IOS native)

Case with editing money request:

Launch New Expensify app.
Force "Offline" mode
Tap + > Request money.
Create a manual request.
Open the IOU details view
Tap Amount
Select some currency.
Go back
Verify offline message will not overlap with the white navigation bar (IOS native)

QA Steps

See above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-edit-offline.mov

android-native-offline.mov

android-native-online.mov

Android: mWeb Chrome

android-chrome-edit-offline.mov

android-chrome-offline.mov

iOS: Native

ios-native-edit-offline.mov

ios_native-offline.mov

ios-native-online.mov

iOS: mWeb Safari

ios-safari-edit-offline.mov

ios-safari-offline.mov

ios-safari-online.mov

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-04T20:42:55Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…eight

fedirjh · 2023-11-06T03:59:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2023-11-06.at.05.36.43.mp4

Android: mWeb Chrome

CleanShot.2023-11-06.at.05.40.12.mp4

iOS: Native

CleanShot.2023-11-06.at.05.20.04.mp4

CleanShot.2023-11-06.at.05.20.52.mp4

iOS: mWeb Safari

CleanShot.2023-11-06.at.05.21.47.mp4

MacOS: Chrome / Safari

MacOS: Desktop

fedirjh · 2023-11-06T04:15:20Z

@sarious Please update offline test, last step to :

Verify offline message will not overlap with the white navigation bar (IOS native)

and for test:

Verify that the keyboard does not flash.

fedirjh · 2023-11-06T04:47:03Z

We have a failed Reassure test.

* commit 'a13b7fd97f35d42d121170270d56bce3e6ecc84e': Prettier wanted import order changed? Update import order Make lint happy fix: remove underscore feat: new emoji font for Windows

sarious · 2023-11-06T07:54:16Z

We have a failed Reassure test.

Oh, I see. What can I do with that? It seems the error is not related to components and files that I was changed. It seem this is an error, because of someone else commits.

sarious · 2023-11-06T15:35:18Z

Now I see that "Reassure Performance Tests" is completed with successful status.
But "Jest Unit Tests" failed, and it's not related to my code.

fedirjh · 2023-11-06T15:38:05Z

@sarious Can you merge main again ? maybe it was fixed on latest main

luacmartins · 2023-11-06T16:10:33Z

I think merging main should fix the issue

luacmartins · 2023-11-06T16:42:17Z

Sorry, closed by accident

luacmartins

Changes LGTM. Can you please merge main to fix the failing test?

puneetlath · 2023-11-06T17:14:03Z

@sarious are you able to do this asap? This is blocking the deploy so we'd like to get this fixed.

luacmartins · 2023-11-06T17:28:26Z

I'm gonna merge this PR with failing jest tests since they are unrelated to the changes in this PR and this is blocking the deploy.

melvin-bot · 2023-11-06T17:29:21Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2023-11-06T17:32:18Z

See above

OSBotify · 2023-11-06T17:33:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix an issue with min height of screen when Offline Indicator is shown (cherry picked from commit bd2d15c)

OSBotify · 2023-11-06T18:05:57Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.3.95-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-11-06T22:07:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sarious · 2023-11-07T06:00:14Z

I think merging main should fix the issue

I wanted to do that at first, but each merge of main branch added new problems. Firstly, it was lint issues, because someone pushed the code without the checks, after that I've got Performance Test Issues and in the end Jets Test Errors.. And all of these errors wasn't related to my code.
So, I thought maybe you can just re-run the all steps (without merging) if this error not related to some task, but just a mystical error.

OSBotify · 2023-11-10T15:44:39Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix an issue with min height of screen when Offline Indicator is shown

6956000

sarious force-pushed the fix/30840 branch from 3c88c7c to 6956000 Compare November 4, 2023 20:20

sarious marked this pull request as ready for review November 4, 2023 20:42

sarious requested a review from a team as a code owner November 4, 2023 20:42

melvin-bot bot removed the request for review from a team November 4, 2023 20:42

melvin-bot bot requested a review from fedirjh November 4, 2023 20:42

remove shouldEnableMaxHeight, because it interferes with work of minH…

46f24ef

…eight

fedirjh approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins November 6, 2023 04:46

sarious force-pushed the fix/30840 branch from a7fd9f8 to 46f24ef Compare November 6, 2023 06:33

Merge commit 'a13b7fd97f35d42d121170270d56bce3e6ecc84e' into fix/30840

db310a7

* commit 'a13b7fd97f35d42d121170270d56bce3e6ecc84e': Prettier wanted import order changed? Update import order Make lint happy fix: remove underscore feat: new emoji font for Windows

luacmartins closed this Nov 6, 2023

luacmartins reopened this Nov 6, 2023

luacmartins approved these changes Nov 6, 2023

View reviewed changes

luacmartins merged commit bd2d15c into Expensify:main Nov 6, 2023
14 of 15 checks passed

melvin-bot bot added the Emergency label Nov 6, 2023

luacmartins changed the title ~~fix an issue with min height of screen when Offline Indicator is shown~~ [CP Stag] fix an issue with min height of screen when Offline Indicator is shown Nov 6, 2023

luacmartins removed the Emergency label Nov 6, 2023

OSBotify pushed a commit that referenced this pull request Nov 6, 2023

Merge pull request #30887 from sarious/fix/30840

782281e

fix an issue with min height of screen when Offline Indicator is shown (cherry picked from commit bd2d15c)

ishpaul777 mentioned this pull request Nov 6, 2023

iOS - Request money - Green CTA button in BNP and confirmation page has different placement #30861

Closed

6 tasks

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

melvin-bot bot mentioned this pull request Nov 6, 2023

[HOLD for payment 2023-12-15] [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #17866

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887

[CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887

sarious commented Nov 4, 2023 •

edited

Loading

melvin-bot bot commented Nov 4, 2023

fedirjh commented Nov 6, 2023 •

edited

Loading

fedirjh commented Nov 6, 2023

fedirjh commented Nov 6, 2023

sarious commented Nov 6, 2023

sarious commented Nov 6, 2023

fedirjh commented Nov 6, 2023

luacmartins commented Nov 6, 2023

luacmartins commented Nov 6, 2023

luacmartins left a comment

puneetlath commented Nov 6, 2023

luacmartins commented Nov 6, 2023 •

edited

Loading

melvin-bot bot commented Nov 6, 2023

luacmartins commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

sarious commented Nov 7, 2023

OSBotify commented Nov 10, 2023

[CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887

[CP Stag] fix an issue with min height of screen when Offline Indicator is shown #30887

Conversation

sarious commented Nov 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 4, 2023

fedirjh commented Nov 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh commented Nov 6, 2023

fedirjh commented Nov 6, 2023

sarious commented Nov 6, 2023

sarious commented Nov 6, 2023

fedirjh commented Nov 6, 2023

luacmartins commented Nov 6, 2023

luacmartins commented Nov 6, 2023

luacmartins left a comment

Choose a reason for hiding this comment

puneetlath commented Nov 6, 2023

luacmartins commented Nov 6, 2023 • edited Loading

melvin-bot bot commented Nov 6, 2023

luacmartins commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

sarious commented Nov 7, 2023

OSBotify commented Nov 10, 2023

sarious commented Nov 4, 2023 •

edited

Loading

fedirjh commented Nov 6, 2023 •

edited

Loading

luacmartins commented Nov 6, 2023 •

edited

Loading